Finish implementing char validation #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeremy
reviewed
Nov 6, 2018
crates/ra_syntax/src/validation.rs
Outdated
| } | ||
|
|
||
| if code.len() > 6 { | ||
| errors.push(SyntaxError::new(OverlongUnicodeEscape, range)); |
There was a problem hiding this comment.
Should there be a return here?
|
I think this is ready to be merged. I could make tests check for expected errors and their range (instead of checking if |
matklad
reviewed
Nov 7, 2018
crates/ra_syntax/src/utils.rs
Outdated
| @@ -78,3 +80,38 @@ pub(crate) fn validate_block_structure(root: SyntaxNodeRef) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| pub struct MutAsciiString<'a> { | |||
There was a problem hiding this comment.
Let's use https://crates.io/crates/arrayvec crate instead?
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2018
207: Finish implementing char validation r=aochagavia a=aochagavia The only thing missing right now are good integration tests (and maybe more descriptive error messages) Co-authored-by: Adolfo Ochagavía <[email protected]>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2018
207: Finish implementing char validation r=aochagavia a=aochagavia The only thing missing right now are good integration tests (and maybe more descriptive error messages) Co-authored-by: Adolfo Ochagavía <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing missing right now are good integration tests (and maybe more descriptive error messages)