Skip to content

Add builtin attributes for use in nameres #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Add builtin attributes for use in nameres #6819

merged 1 commit into from
Dec 11, 2020

Conversation

jonas-schievink
Copy link
Contributor

These are not yet used, but have to go through nameres later in order to support procedural macro attributes

Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -0,0 +1,428 @@
//! Builtin attributes resolved by nameres.
//!
//! The actual definitions were copied from rustc's `compiler/rustc_feature/src/builtin_attrs.rs`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay library-ification!

@jonas-schievink
Copy link
Contributor Author

bors r+

@@ -0,0 +1,428 @@
//! Builtin attributes resolved by nameres.
//!
//! The actual definitions were copied from rustc's `compiler/rustc_feature/src/builtin_attrs.rs`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the exact commit you copied it from? It could be useful in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good idea. Opened #6832.

@bors
Copy link
Contributor

bors bot commented Dec 11, 2020

@bors bors bot merged commit 3674e49 into rust-lang:master Dec 11, 2020
@jonas-schievink jonas-schievink deleted the builtin-attrs branch December 11, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants