Implement more precise binary op return type heuristic #8457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flodiebold |
Veykril
commented
Apr 10, 2021
crates/hir_ty/src/tests/traits.rs
Outdated
Comment on lines
1939
to
1946
| 98..99 'g': |u64| -> i32 | ||
| 102..111 '|v| v + 1': |u64| -> i32 | ||
| 98..99 'g': |u64| -> {unknown} | ||
| 102..111 '|v| v + 1': |u64| -> {unknown} | ||
| 103..104 'v': u64 | ||
| 106..107 'v': u64 | ||
| 106..111 'v + 1': i32 | ||
| 106..111 'v + 1': {unknown} | ||
| 110..111 '1': i32 | ||
| 117..118 'g': |u64| -> i32 | ||
| 117..124 'g(1u64)': i32 | ||
| 117..118 'g': |u64| -> {unknown} | ||
| 117..124 'g(1u64)': {unknown} |
There was a problem hiding this comment.
This involves a general InferenceVar which results in these not resolving anymore since we can't make assumptions for those as well as not having std's ops implementation in scope in the tests
There was a problem hiding this comment.
Hm. Can we add the necessary impls to the test to make this work?
There was a problem hiding this comment.
Oops, ye should've done that from the start. Resolves with those impls added.
Veykril
changed the title
|
r=me, though it'd also be nice to add a test for #7150. |
|
bors r=flodiebold |
|
changelog fix Don't assume wrong binary operator return type when primitives are involved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #7150