fix: Respect coercions in inline_call
#9557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Jul 10, 2021
9557: fix: Respect coercions in `inline_call` r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
|
Build failed: |
|
bors retry |
flodiebold
reviewed
Jul 10, 2021
| @@ -216,14 +216,18 @@ impl<'db, DB: HirDatabase> Semantics<'db, DB> { | |||
| self.imp.type_of_expr(expr) | |||
| } | |||
|
|
|||
| pub fn type_of_expr_with_coercion(&self, expr: &ast::Expr) -> Option<Type> { | |||
| pub fn type_of_expr_with_coercion(&self, expr: &ast::Expr) -> Option<(Type, Option<Type>)> { | |||
There was a problem hiding this comment.
I think it's very unclear what this returns now 😬
There was a problem hiding this comment.
I think an API that always returns the adjusted type (which might be the original one if there are no adjustments) would be much clearer. For cases where we want to see whether an adjustment happened, we could return the list of adjustments additionally, or even just a boolean?
There was a problem hiding this comment.
Yea, that sounds reasonable. I'll fix that up later today/tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+