-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Missing config #10248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing config #10248
Conversation
COLLAPSIBLE_STR_REPLACE uses msrvs::PATTERN_TRAIT_CHAR_ARRAY
SEEK_FROM_CURRENT uses msrvs::SEEK_FROM_CURRENT
SEEK_REWIND uses msrvs::SEEK_REWIND
UNNECESSARY_LAZY_EVALUATIONS uses msrvs::BOOL_THEN_SOME for `then` to `then_some`
TRANSMUTE_PTR_TO_REF uses msrvs::POINTER_CAST
ALMOST_COMPLETE_RANGE uses msrvs::RANGE_INCLUSIVE
NEEDLESS_BORROW uses msrvs::ARRAY_INTO_ITERATOR
DERIVABLE_IMPLS uses msrvs::DEFAULT_ENUM_ATTRIBUTE
MANUAL_IS_ASCII_CHECK uses msrvs::IS_ASCII_DIGIT and msrvs::IS_ASCII_DIGIT_CONST
MANUAL_REM_EUCLID uses msrvs::REM_EUCLID
MANUAL_RETAIN uses - msrvs::STRING_RETAIN - msrvs::BTREE_SET_RETAIN - msrvs::BTREE_MAP_RETAIN - msrvs::HASH_SET_RETAIN - msrvs::HASH_MAP_RETAIN
Looks good to me, thank you for updating the documentation! @bors r+ I skimmed over the prototype, and like the idea of having a static instance to access the configuration. We could maybe think of forcing the user to specify a lint, to access a config struct, something like: fn config(lint: &Lint) -> &Config {
// The typical static magic
} Then we could have an internal lint detecting access to that method. This is just a quick thought, without testing anything. If you're stuck somewhere or would just get some more information, feel free to ping me :) |
Missing config This PR addresses https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Some.20lints.20miss.20its.20config/near/318460000. changelog: Documentation: Made sure that lint configurations on Clippy's lint list are all up to date [#10248](#10248) <!-- changelog_checked --> r? `@xFrednet` --- I have tried to create [a prototype](koka831#1), but have not yet found a good way to implement it. So I would like to put it aside for now and try again after addressing other issues so that I can understand how clippy works better:)
f576a97
to
a9e6b12
Compare
@xFrednet Thank you for quick review:) Could you review it again please?
Yes, that's what I've seeking. I actually could do this dynamically, but I'm wondering how could it be statically. |
What do you consider dynamic / static in this regard? Fetching the config would be dynamic, but the lint would analyze the static expression 🤔 The changes still look good! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR addresses https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Some.20lints.20miss.20its.20config/near/318460000.
changelog: Documentation: Made sure that lint configurations on Clippy's lint list are all up to date
#10248
r? @xFrednet
I have tried to create a prototype, but have not yet found a good way to implement it.
So I would like to put it aside for now and try again after addressing other issues so that I can understand how clippy works better:)