Skip to content

needless_range_loop: improve documentation #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 29, 2023

fixes #6929

changelog: [needless_range_loop]: improve documentation

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 29, 2023
@ChrisJefferson
Copy link

I think there are further improvements to be made here, but this is an improvement over what was there before.

@tylerjw
Copy link
Contributor Author

tylerjw commented Jan 29, 2023

What would you like it to also do?

@ChrisJefferson
Copy link

Sorry, I should have been clearer.

There is also #6930 , which discusses how this needless_range_loop can change behaviour -- however I think that should be dealt with separately, if for no other reason than it's not clear (to me) if the fix should be making this clear in the docs, or changing the suggestion.

@tylerjw
Copy link
Contributor Author

tylerjw commented Jan 29, 2023

Thank you for clarifying. I read that other issue and I'm unsure what change to make for it, that is why I only linked the issue about clarifying the docs.

@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jan 30, 2023

📌 Commit 5ed191d has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 30, 2023

⌛ Testing commit 5ed191d with merge d92070a...

@bors
Copy link
Contributor

bors commented Jan 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing d92070a to master...

@bors bors merged commit d92070a into rust-lang:master Jan 30, 2023
@tylerjw tylerjw deleted the issue_6929 branch January 30, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation of needless_range_loop
5 participants