-
Notifications
You must be signed in to change notification settings - Fork 1.7k
needless_range_loop: improve documentation #10254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
I think there are further improvements to be made here, but this is an improvement over what was there before. |
What would you like it to also do? |
Sorry, I should have been clearer. There is also #6930 , which discusses how this needless_range_loop can change behaviour -- however I think that should be dealt with separately, if for no other reason than it's not clear (to me) if the fix should be making this clear in the docs, or changing the suggestion. |
Thank you for clarifying. I read that other issue and I'm unsure what change to make for it, that is why I only linked the issue about clarifying the docs. |
Co-authored-by: Manish Goregaokar <[email protected]>
@bors r+ thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #6929
changelog: [
needless_range_loop
]: improve documentation