Improve mut_mut and collapsible_if
#1032
Conversation
| @@ -1,6 +1,9 @@ | |||
| # Change Log | |||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## 0.0.78 — TBD | |||
| * [`collapsible_if`] now consider `if let` | |||
| let y : &mut &mut &mut u32 = &mut &mut &mut 2; | ||
| //~^ ERROR generally you want to avoid `&mut &mut | ||
| //~| ERROR generally you want to avoid `&mut &mut | ||
| //~| ERROR generally you want to avoid `&mut &mut | ||
| //~| ERROR generally you want to avoid `&mut &mut | ||
| //~| ERROR generally you want to avoid `&mut &mut | ||
| //~| ERROR generally you want to avoid `&mut &mut |
There was a problem hiding this comment.
Do we really need so many warnings?
There was a problem hiding this comment.
The PR fixes an actual annoying bug with for _ in &mut bar but in this case also duplicates some errors. On the other hand &mut &mut &mut is such a corner case I did not think it would be worth it to try to deduplicate errors here.
|
The OTOH, with the new error formatting we probably don't need to care. |
|
|
It doesn't need any `hir` feature and `ast` is much more stable.
|
Rebased and removed 472e7ca. Is it so bad that it reports duplicated commits on such convoluted example? |
|
I can fix it later. |
Fix #939.