Stop doc_markdown requiring backticks on links to external websites #10357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
nindalf
force-pushed
the
doc_markdown_relax
branch
3 times, most recently
from
d8774e9 to
ea92b49
Compare
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Feb 16, 2023
Stop doc_markdown requiring backticks on links to external websites Fixes #10302 This lint currently checks that any link should be enclosed with `backticks` if the title looks like a lang item. This PR changes the lint to only run on internal links. External links, indicated by `http` or `https`, are skipped. --- changelog: Stop doc_markdown requiring backticks on links to external websites
|
💔 Test failed - checks-action_test |
nindalf
force-pushed
the
doc_markdown_relax
branch
from
ea92b49 to
9c9dbc2
Compare
|
Sorry, I had missed that. @bors retry |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10302
This lint currently checks that any link should be enclosed with
backticksif the title looks like a lang item. This PR changes the lint to only run on internal links. External links, indicated byhttporhttps, are skipped.This PR also reorganises
pulldown_cmarkimports to bypass the clippy lint enforcing 100 line functions.changelog: Stop doc_markdown requiring backticks on links to external websites