-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update readme description of restriction
lints to dissuade casual use.
#10385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
ec4eff6
to
8631a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion, otherwise it looks good to me. I like that the table now contains all categories :)
8631a1e
to
bf7c209
Compare
Looks good to me, thank you! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book.
The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book.
Consistent lint group table in book and README The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book. r? `@xFrednet` I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI. This is just copy and paste of the current README file on `master`. changelog: none
Consistent lint group table in book and README The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book. r? `@xFrednet` I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI. This is just copy and paste of the current README file on `master`. changelog: none
Adds some stronger wording about not enabling
restriction
lints. I've seen it come up a few times where people are confused about what therestriction
category is for and end up casually enabling lints from it (or the whole category).changelog: None