Skip to content

Update readme description of restriction lints to dissuade casual use. #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Feb 21, 2023

Adds some stronger wording about not enabling restriction lints. I've seen it come up a few times where people are confused about what the restriction category is for and end up casually enabling lints from it (or the whole category).

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 21, 2023
@Jarcho Jarcho force-pushed the readme_restriction branch from ec4eff6 to 8631a1e Compare February 21, 2023 17:10
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, otherwise it looks good to me. I like that the table now contains all categories :)

@Jarcho Jarcho force-pushed the readme_restriction branch from 8631a1e to bf7c209 Compare February 22, 2023 03:05
@xFrednet
Copy link
Member

Looks good to me, thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2023

📌 Commit bf7c209 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 22, 2023

⌛ Testing commit bf7c209 with merge 8d08917...

@bors
Copy link
Contributor

bors commented Feb 22, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 8d08917 to master...

@bors bors merged commit 8d08917 into rust-lang:master Feb 22, 2023
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Apr 8, 2024
The lint table and the restriction group description was improved in rust-lang#10385,
but only in the README. Apply the same changes to the book.
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Apr 9, 2024
The lint table and the restriction group description was improved in rust-lang#10385,
but only in the README. Apply the same changes to the book.
bors added a commit that referenced this pull request Apr 9, 2024
Consistent lint group table in book and README

The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book.

r? `@xFrednet`

I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI.

This is just copy and paste of the current README file on `master`.

changelog: none
bors added a commit that referenced this pull request Apr 9, 2024
Consistent lint group table in book and README

The lint table and the restriction group description was improved in #10385, but only in the README. Apply the same changes to the book.

r? `@xFrednet`

I noticed that I left review comments about this in #10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI.

This is just copy and paste of the current README file on `master`.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants