fix [cast_possible_truncation] offering wrong suggestion for casting float to integer
#10496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexendoo
reviewed
Mar 13, 2023
|
r? @Alexendoo Would you mind, since you already gave some feedback? 🙃 |
Alexendoo
reviewed
Mar 22, 2023
Alexendoo
reviewed
Mar 24, 2023
…ng from float suggest `try_into` when casting to wildcard type; fix [`cast_possible_truncation`] suggesting useless parenthesis; remove suggesting for float to float conversion in [`cast_possible_truncation`] style nit
Alexendoo
approved these changes
Mar 25, 2023
|
Thanks @J-ZhengLi! @bors r+ |
bors
added a commit
that referenced
this pull request
Mar 25, 2023
fix [`cast_possible_truncation`] offering wrong suggestion for casting float to integer fixes: #10366 --- changelog: fix [`cast_possible_truncation`] offering wrong suggestion for casting from float types, and to wildcard type;
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #10366
changelog: [
cast_possible_truncation] Fix incorrect suggestions when casting from float types or to_