Update changelog's data ranges #11027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Manishearth
approved these changes
Jun 26, 2023
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 26, 2023
Update changelog's data ranges Related to #10847 Instead of the non-descriptive commit ranges, now the changelog uses dates (much more illustrative, and cooler 😎 ) changelog:none
|
💥 Test timed out |
|
I'll wait for flip's comments to be addressed |
Manishearth
approved these changes
Jun 26, 2023
Manishearth
reviewed
Jun 26, 2023
| @@ -56,6 +56,29 @@ and open that file in your editor of choice. | |||
| When updating the changelog it's also a good idea to make sure that `commit1` is | |||
| already correct in the current changelog. | |||
|
|
|||
| #### From commit range to PR link | |||
|
|
|||
| Raw commit ranges aren't used, they aren't very useful or illustrative, so we developed the concept of PR ranges to help the user understand the size of a new update. | |||
There was a problem hiding this comment.
hm, it's less useful to mention the old model here.
Let's just document what we do, rather than what we used to do
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 26, 2023
Update changelog's data ranges Related to #10847 Instead of the non-descriptive commit ranges, now the changelog uses dates (much more illustrative, and cooler 😎 ) changelog:none
|
💔 Test failed - checks-action_remark_test |
|
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10847
Instead of the non-descriptive commit ranges, now the changelog uses dates (much more illustrative, and cooler 😎 )
changelog:none