[unused_async]: don't lint if function is part of a trait
#11042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Manishearth
requested changes
Jun 28, 2023
clippy_lints/src/unused_async.rs
Outdated
| /// Checks if the `def_id` belongs to a function and that function is part of a trait impl, | ||
| /// in which case we shouldn't lint because `async` is part of the trait definition and therefore | ||
| /// can't be removed. | ||
| fn is_in_trait_impl(cx: &LateContext<'_>, def_id: LocalDefId) -> bool { |
There was a problem hiding this comment.
issue: this should be in utils somewhere. there's also a chance we already have it
(@Centri3 got opinions where?)
There was a problem hiding this comment.
I don't think we already have it, we have some for MethodCalls and such but not DefIds themselves
I think just the top-level clippy_utils is fine. The other is_trait_method function is there too. We could probably rename this to is_def_id_trait_method or something for consistency's sake.
Manishearth
approved these changes
Jun 28, 2023
|
@bors r+ thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10459.
We shouldn't lint if the function is part of a trait, because the user won't be able to easily remove the
async, as this will then not match with the function signature in the trait definitionchangelog: [
unused_async]: don't lint if function is part of a trait