Skip to content

Use cargo build --tests in CI #11053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

Alexendoo
Copy link
Member

I noticed that we run a cargo build but end up downloading/building a bunch of deps after that for tests in CI

https://github.com/rust-lang/rust-clippy/actions/runs/5426673277/jobs/9869019973#step:6:12
https://github.com/rust-lang/rust-clippy/actions/runs/5426673277/jobs/9869019973#step:7:11

This builds the tests in the build step too, it may speed up runs by downloading/building more in parallel

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 30, 2023
@flip1995
Copy link
Member

flip1995 commented Jul 2, 2023

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 2, 2023

📌 Commit 2f7f139 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 2, 2023

⌛ Testing commit 2f7f139 with merge 17a48c2...

@bors
Copy link
Contributor

bors commented Jul 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 17a48c2 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jul 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 17a48c2 to master...

@bors bors merged commit 17a48c2 into rust-lang:master Jul 2, 2023
@Alexendoo Alexendoo deleted the ci-build-tests branch July 2, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants