-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix the uitest enum_clike_unportable_variant
#11391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the uitest enum_clike_unportable_variant
#11391
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks! I just noticed that this test case is ignored on x86. This means that we never run it on CI, because there we only have x86 machines. 🤔 |
I think that's because ignoring x86 includes x86_64 in ui_test but didn't in compiletest, |
update an uitest stderr update uitest enum_clike_unportable_variant
8ae942b
to
d2f6522
Compare
enum_clike_unportable_variant
@Alexendoo Yea, you're right. The code has been updated accordingly. |
Thanks! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: none