Skip to content

fix the uitest enum_clike_unportable_variant #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kiscad
Copy link
Contributor

@kiscad kiscad commented Aug 24, 2023

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2023
@flip1995
Copy link
Member

Thanks!

I just noticed that this test case is ignored on x86. This means that we never run it on CI, because there we only have x86 machines. 🤔

@Alexendoo
Copy link
Member

I think that's because ignoring x86 includes x86_64 in ui_test but didn't in compiletest, //@ignore-32bit is probably what it wants to be

update an uitest stderr

update uitest enum_clike_unportable_variant
@kiscad kiscad force-pushed the fix-uitest-enum_clike_unportable_variant branch from 8ae942b to d2f6522 Compare August 26, 2023 01:35
@kiscad kiscad changed the title update an uitest stderr fix the uitest enum_clike_unportable_variant Aug 26, 2023
@kiscad
Copy link
Contributor Author

kiscad commented Aug 26, 2023

@Alexendoo Yea, you're right. The code has been updated accordingly.

@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit d2f6522 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit d2f6522 with merge 74a46a7...

@bors
Copy link
Contributor

bors commented Aug 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 74a46a7 to master...

@bors bors merged commit 74a46a7 into rust-lang:master Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants