Add a builtin_type_shadow lint
#1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,27 @@ declare_lint! { | |||
| "integer literals starting with `0`" | |||
| } | |||
|
|
|||
| /// **What it does:** Warns if a generic shadows a built-in type. | |||
| /// | |||
| /// **Why is this bad?** This gives surprising type error. | |||
There was a problem hiding this comment.
Either 'errors' or 'a surprising type error'
mcarton
force-pushed
the
shadow-builtin
branch
from
e8f6983 to
d87f137
Compare
|
Rebased and addressed comments. |
|
LGTM I was confused by the wording ("shadowing") a bit, bit it makes sense. (Maybe we can add a span label for the generic name later on, saying something like "The generic |
|
Good lint. @Manishearth we should propose adding this to rustc. It's really a footgun. |
|
Not as a lint, but that error message could get a help message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#36046.
Close #949.