Skip to content

6459: Check for redundant matches! with Ready, Pending, V4, V6 #12029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

torfsen
Copy link
Contributor

@torfsen torfsen commented Dec 27, 2023

Fixes #6459.

changelog: [`redundant_pattern_matching`]: Add checks for `Poll::{Ready,Pending}` and `IpAddr::{V4,V6}` in `matches!`

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 27, 2023
@torfsen torfsen force-pushed the 6459-more-cases-for-redundant-matches! branch from 800b4f5 to ebc0588 Compare December 27, 2023 18:10
@torfsen torfsen changed the title 6459: Check fo redundant matches! with Ready, Pending, V4, V6 6459: Check for redundant matches! with Ready, Pending, V4, V6 Dec 27, 2023
@llogiq
Copy link
Contributor

llogiq commented Dec 27, 2023

Thank you, this looks good to me.

@bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2023

📌 Commit ebc0588 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 27, 2023

⌛ Testing commit ebc0588 with merge 7343db9...

@bors
Copy link
Contributor

bors commented Dec 27, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 7343db9 to master...

@bors bors merged commit 7343db9 into rust-lang:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on matches! with rule redundant_pattern_matching?
4 participants