Skip to content

Temporary review vacation to focus on performance #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Feb 9, 2024

We are at Feb. 9, I have done practically nothing in regards to performance and bors just keeps giving me reviews, so I'm going to set myself on vacation on this repo and reroll some PRs. Sadly I cannot postpone performance for reviews.

I'll revert this commit on 12-15 days. I'd love to the discussion in this Zulip thread to make some progress so that I don't have to get into version control my busyness status.

changelog:none
r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 9, 2024
@blyxyas
Copy link
Member Author

blyxyas commented Feb 9, 2024

Based on this message by Nilstrieb:

(we don't really require reviews for things like setting yourself on vacation, it's fine to self approve that)

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2024

📌 Commit 0d69602 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 9, 2024

⌛ Testing commit 0d69602 with merge fb398a5...

@bors
Copy link
Contributor

bors commented Feb 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing fb398a5 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing fb398a5 to master...

@bors bors merged commit fb398a5 into rust-lang:master Feb 9, 2024
@bors
Copy link
Contributor

bors commented Feb 9, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants