-
Notifications
You must be signed in to change notification settings - Fork 1.7k
style: sync GitHub Corner colors #12350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: sync GitHub Corner colors #12350
Conversation
@hamirmahal: no appropriate reviewer found, use r? to override |
Without this changeScreencast.from.02-25-2024.11.38.25.AM.webm |
With this changeScreencast.from.02-25-2024.11.39.55.AM.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to adapt the color to the theme look good to me. I liked the shadow cat beforehand as well, but this is nicer :D
The last time, you were able to undo the formatting, to keep the original one, can you do the same for this PR?
Some context for the formatting: I don't have anything against this formatting or another one. It's more the fact that everyone might have different settings, and the next PR might then reformat everything again.
For Rust we have rustfmt which enforces the same format everywhere, but we have nothing like that for HTML. We could potentially add one to the CI, but I don't really think it's worth it.
Absolutely! That all makes sense. I just updated the commits. |
Perfection, like last time. Thank you very much :D @bors r+ |
You're welcome! And thank you. |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #12349.
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: sync site GitHub Corner colors