Skip to content

style: sync GitHub Corner colors #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
Merged

style: sync GitHub Corner colors #12350

merged 2 commits into from
Feb 26, 2024

Conversation

hamirmahal
Copy link
Contributor

fixes #12349.

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: sync site GitHub Corner colors

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2024

@hamirmahal: no appropriate reviewer found, use r? to override

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 25, 2024
@hamirmahal
Copy link
Contributor Author

Without this change

Screencast.from.02-25-2024.11.38.25.AM.webm

@hamirmahal
Copy link
Contributor Author

With this change

Screencast.from.02-25-2024.11.39.55.AM.webm

@xFrednet xFrednet self-assigned this Feb 25, 2024
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to adapt the color to the theme look good to me. I liked the shadow cat beforehand as well, but this is nicer :D

The last time, you were able to undo the formatting, to keep the original one, can you do the same for this PR?

Some context for the formatting: I don't have anything against this formatting or another one. It's more the fact that everyone might have different settings, and the next PR might then reformat everything again.

For Rust we have rustfmt which enforces the same format everywhere, but we have nothing like that for HTML. We could potentially add one to the CI, but I don't really think it's worth it.

@hamirmahal
Copy link
Contributor Author

Absolutely! That all makes sense. I just updated the commits.

@xFrednet
Copy link
Member

Perfection, like last time. Thank you very much :D

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2024

📌 Commit 3ef693c has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 26, 2024

⌛ Testing commit 3ef693c with merge b09fb8a...

@hamirmahal
Copy link
Contributor Author

You're welcome! And thank you.

@bors
Copy link
Contributor

bors commented Feb 26, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing b09fb8a to master...

@bors bors merged commit b09fb8a into rust-lang:master Feb 26, 2024
@hamirmahal hamirmahal deleted the style/sync-GitHub-Corner-colors branch February 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Corner colors don't sync with the rest of the page
4 participants