[let_underscore_untyped]: fix false positive on async function
#12400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use r? to explicitly pick a reviewer |
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Mar 3, 2024
clippy_lints/src/let_underscore.rs
Outdated
| @@ -200,7 +200,7 @@ impl<'tcx> LateLintPass<'tcx> for LetUnderscore { | |||
| } | |||
|
|
|||
| // Ignore if it is from a procedural macro... | |||
| if is_from_proc_macro(cx, init) { | |||
| if is_from_proc_macro(cx, init) || init.span.from_expansion() { | |||
There was a problem hiding this comment.
Let's check if local.source is Normal at the top of the function since it would be fine to lint let _ = some_macro!();, we can remove the default_binding_modes check also in that case
There was a problem hiding this comment.
Indeed, I hadn't noticed the source field. Done.
samueltardieu
force-pushed
the
issue-12395
branch
from
952d216 to
1df2854
Compare
Alexendoo
approved these changes
Mar 3, 2024
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
let_underscore_untyped]: fix false positive on async functionFix #12395