Skip to content

Move box_default to style, do not suggest turbofishes #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Alexendoo
Copy link
Member

Box::default() had its #[rustc_box] attribute removed in 1.69 so is no longer a perf related lint

The lint is moved to style but no longer produces suggestions containing turbofishes, as they're often longer/more annoying to type

changelog: [box_default]: Move to style

r? @llogiq

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 31, 2024
`Box::default()` had its `#[rustc_box]` attribute removed in 1.69 so is
no longer a perf related lint

The lint is moved to style but no longer produces suggestions containing
turbofishes, as they're often longer/more annoying to type
@llogiq
Copy link
Contributor

llogiq commented Apr 1, 2024

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit 0f63fa8 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 1, 2024

⌛ Testing commit 0f63fa8 with merge cb87a57...

@bors
Copy link
Contributor

bors commented Apr 1, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing cb87a57 to master...

@bors bors merged commit cb87a57 into rust-lang:master Apr 1, 2024
@Alexendoo Alexendoo deleted the box-default-style branch April 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants