Rephrase and expand empty_enum
documentation.
#12833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!
, a newtype struct, or keep the enum.Before writing this change, I asked the community via IRLO and Zulip for feedback. The broad consensus seemed to me to be that in a world where both
never_type
andmin_exhaustive_patterns
are stable and therefore available for general use, we might want to!
or newtypes of it — but it's certainly not “conventional” yet. Therefore, I've removed “conventional” and added a discussion of the pros and cons of different choices.changelog: [
empty_enum
]: expanded documentation