Remove lazy_static mention

[Alexendoo]

I planned to replace any mention with LazyLock but I think thread_local is more appropriate here - consts that aren't Sync wouldn't be able to go in a lazy_static/static LazyLock either

Also removed a test file that was mostly commented out so wasn't testing anything

changelog: none

[rustbot]

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[llogiq]

I do worry that without further documentation the suggestion to make a static or thread_local isn't very helpful. Could we amend the lint docs to give some guidance when to use what?

[Alexendoo]

Updated it to not mention thread_local if it's already Sync and make it a bit clearer that it's the fallback solution

[llogiq]

That works for me. Thank you!

@bors r+

[bors]

📌 Commit 65af5d7 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit 65af5d7 with merge 0ea88b9...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 0ea88b9 to master...