Skip to content

Fix while_let_on_iterator dropping loop label when applying fix. #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

jusexton
Copy link
Contributor

Loop label was not persisted when displaying help and was therefore producing broken rust code when applying fixes.

Solution was to store the ast::Label when creating a higher::WhileLet from an expression and add the label name to the lint suggestion and diagnostics.


Fixes: #13123

changelog: [while_let_on_iterator]: Fix issue dropping loop label when displaying help and applying fixes.

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2024
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dswij
Copy link
Member

dswij commented Jul 27, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 27, 2024

📌 Commit 0cdf6e1 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 27, 2024

⌛ Testing commit 0cdf6e1 with merge d20be39...

@bors
Copy link
Contributor

bors commented Jul 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing d20be39 to master...

@bors bors merged commit d20be39 into rust-lang:master Jul 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect fix (loop labels lost) when turning while loop to for loop
4 participants