-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix-typos #13194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-typos #13194
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
ok @Jarcho |
Do you think I should revert the changes for LintcheckConfig? |
Yes. Reverting just the second commit would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to have the commits squashed and then we're good.
@Jarcho who will squashed the commits ? |
You will have to. |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
2043d9f
to
7f13881
Compare
I would generally use |
so what should i do next ? |
Assuming your local state and github's are the same the easiest way would be Note that |
7f13881
to
b9716dd
Compare
thanks it worked |
Thank you. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes some typos in lintcheck
changelog: None