Add clarification for from_iter_instead_of_collect #13208
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Thanks for the PR. One thing I'd like changed is that we always put code snippets in back ticks, even when just naming a type, which your comment currently doesn't. Also when naming a call with one argument, we use an underscore for the call, e.g. from_iter(_). Other than that, this is a solid improvement, and I'll happily merge it once fixed.
clippy_lints/src/methods/mod.rs
Outdated
| /// It is recommended style to use collect. See | ||
| /// If it's needed to create a collection from the contents of an iterator, the Iterator::collect() | ||
| /// method is preferred. However, when it's needed to specify the container type, | ||
| /// FromIterator::from_iter() can be more readable than using a turbofish (e.g. ::<Vec<_>>()). See |
There was a problem hiding this comment.
Wouldn't it make more sense to use e.g. Vec::from_iter(_) as an example here?
alex-semenyuk
force-pushed
the
fix_doc_from_iter_instead_of_collect
branch
from
430b500 to
4bb6b30
Compare
@llogiq Thanks for feedback. Done |
clippy_lints/src/methods/mod.rs
Outdated
| @@ -1892,7 +1892,9 @@ declare_clippy_lint! { | |||
| /// trait. | |||
| /// | |||
| /// ### Why is this bad? | |||
| /// It is recommended style to use collect. See | |||
| /// If it's needed to create a collection from the contents of an iterator, the `Iterator::collect()` | |||
There was a problem hiding this comment.
This should either be Iterator::collect(self), Iterator::collect(_) or simply _.collect().
alex-semenyuk
force-pushed
the
fix_doc_from_iter_instead_of_collect
branch
from
4bb6b30 to
4d3a9e7
Compare
alex-semenyuk
force-pushed
the
fix_doc_from_iter_instead_of_collect
branch
from
4d3a9e7 to
35dcc9b
Compare
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Close #13147
As mentioned at #13147 we should prefer to use collect depends on situation so clarify this at documentation and provide examples this cases.
changelog: none