Add '--version' flag and allow version and help flags when called as 'cargo-clippy' #1328
Conversation
| metadata | ||
| } else { | ||
| let _ = io::stderr().write_fmt(format_args!("error: Could not obtain cargo metadata.")); | ||
| process::exit(101); |
There was a problem hiding this comment.
we have a pretty random policy with panics vs process::exit, so I guess this is fine. What's the reason for this change though?
There was a problem hiding this comment.
Ah, actually this was just because I dislike seeing stack traces when running tools. And I'd just done something similar for 'cargo-check' so I thought "might as well".
There was a problem hiding this comment.
there's a million other cases where cargo clippy can panic. I think we should do a clean refactor of the main function to use Result based error handling and then have a single location that calls process::exit but that's for a different PR :)
| println!("{}", env!("CARGO_PKG_VERSION")); | ||
| } | ||
|
|
||
| #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] |
There was a problem hiding this comment.
why is this attribute added? And why only under the cargo-clippy feature?
|
It was just an artifact from when I was trying to please the dogfood test. Removed now. |
|
thanks! |
This makes it easier to integrate 'cargo clippy' into other tools.
(Or at least makes it possible to reason about the capabilities of the tool based on its version).