Skip to content

Fix large_include_file lint being triggered all the time by doc comments #13672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #13670.

Bug was that I forgot to add the comparison with the included file content length...

changelog: Fix large_include_file lint being triggered all the time by doc comments

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 9, 2024
@Manishearth Manishearth added this pull request to the merge queue Nov 9, 2024
Merged via the queue into rust-lang:master with commit 4f0e46b Nov 9, 2024
9 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-large_include_file branch November 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive large_include_file with a small #[doc = include_str("../README.md")]
3 participants