Skip to content

Update doc wildcard_dependencies #13810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Dec 11, 2024

Currently https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_dependencies doc doesn't contain explanation how it should be so added more details


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 11, 2024
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from 03491c8 to ff27097 Compare December 11, 2024 08:07
Jarcho
Jarcho previously requested changes Dec 14, 2024
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the missing example.

@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from ff27097 to 7ddfed2 Compare December 14, 2024 12:01
@alex-semenyuk alex-semenyuk requested a review from Jarcho December 14, 2024 12:11
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch 3 times, most recently from 1d9baff to cf331d2 Compare December 20, 2024 19:54
@alex-semenyuk
Copy link
Member Author

r? clippy

@rustbot rustbot assigned llogiq and unassigned Jarcho Jan 7, 2025
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from cf331d2 to 3f4aa9b Compare January 17, 2025 20:20
@alex-semenyuk alex-semenyuk requested a review from llogiq January 17, 2025 20:29
@llogiq llogiq dismissed Jarcho’s stale review January 17, 2025 21:30

The points raised have been addressed.

@llogiq llogiq added this pull request to the merge queue Jan 17, 2025
@llogiq
Copy link
Contributor

llogiq commented Jan 17, 2025

Thank you.

Merged via the queue into rust-lang:master with commit 10045db Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants