Use a better message for toplevel_ref_arg lint
#14132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
|
Don't hesitate to suggest an even clearer message |
Manishearth
reviewed
Feb 1, 2025
clippy_lints/src/misc.rs
Outdated
| @@ -169,7 +169,7 @@ impl<'tcx> LateLintPass<'tcx> for LintPass { | |||
| TOPLEVEL_REF_ARG, | |||
| arg.hir_id, | |||
| arg.pat.span, | |||
| "`ref` directly on a function argument is ignored. \ | |||
| "`ref` directly on a function argument requires ownership of the argument nonetheless. \ | |||
There was a problem hiding this comment.
"does not prevent taking ownership of the passed parameter"
There was a problem hiding this comment.
Better.
I suggest: "ref directly on a function parameter does not prevent taking ownership of the passed argument" which is stricter in terms of param/arg. Is that ok?
A `ref` pattern applied to an argument is not ignored. It creates a reference as expected, but still requires the function to take ownership of the argument given to it.
samueltardieu
force-pushed
the
push-uxzmzkkulryr
branch
from
4703aec to
7848488
Compare
Manishearth
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
refpattern applied to an argument is not ignored. It creates a reference as expected, but still requires the function to take ownership of the argument given to it.Fix #14131
changelog: [
toplevel_ref_arg]: use a clearer lint message