extend obfuscated_if_else to support {then(), then_some()}.unwrap_or_else()
#14165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
obfusifelse_unwraporelse
branch
3 times, most recently
from
4c00a09 to
9642c7d
Compare
|
Rebased. |
lapla-cogito
force-pushed
the
obfusifelse_unwraporelse
branch
from
9642c7d to
264403a
Compare
|
Rebased. |
|
@blyxyas Should I reassign? (I pinged you because it's been over 2 weeks) |
|
Sorry, this issue in particular has slipped under the radar on my org system. I will get a review today (I will start a review right now) |
blyxyas
requested changes
Feb 21, 2025
lapla-cogito
force-pushed
the
obfusifelse_unwraporelse
branch
3 times, most recently
from
66d3a9c to
a8a6598
Compare
…`then_some().unwrap_or_else()`
lapla-cogito
force-pushed
the
obfusifelse_unwraporelse
branch
from
a8a6598 to
6c6ffd2
Compare
blyxyas
approved these changes
Feb 24, 2025
rye
added a commit
to frog-pond/ccc-server-next
that referenced
this pull request
Apr 10, 2025
With Rust 1.87 beta, clippy started warning about some new instances of the obfuscated-if-else lint. This appears to have been introduced in rust-lang/rust-clippy#14165, which was a change that made sense to me. But because we deny the warn-by-default group, clippy::all, CI began failing, which is fine. This commit resolves the two instances of this lint in the codebase by using inline if-else's. Signed-off-by: Kristofer Rye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These method chains can be expressed concisely with
if/else.changelog: [
obfuscated_if_else]: supportthen().unwrap_or_else()andthen_some().unwrap_or_else()