New lint: mem_replace_option_with_some
#14197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-qyyrwsvsuvyw
branch
from
6de91d5 to
8af4abd
Compare
|
Hits from lintcheck are legitimate. |
llogiq
requested changes
Feb 12, 2025
clippy_lints/src/mem_replace.rs
Outdated
| @@ -238,6 +283,13 @@ impl<'tcx> LateLintPass<'tcx> for MemReplace { | |||
| } else if self.msrv.meets(msrvs::MEM_TAKE) && is_expr_used_or_unified(cx.tcx, expr) { | |||
| check_replace_with_default(cx, src, dest, expr.span); | |||
| } | |||
| // Check that second argument is `Option::Some` | |||
There was a problem hiding this comment.
Shouldn't that be part of the check method? To me as a reviewer, this splits the code and if I look at the check method in isolation, it's not clear what actually is checked.
There was a problem hiding this comment.
Totally. I have also reorganized the other checks so that they are more self-contained, in the first commit.
clippy_lints/src/mem_replace.rs
Outdated
| /// | ||
| /// ### Example | ||
| /// ```no_run | ||
| /// use std::mem; |
There was a problem hiding this comment.
This is only used once, so we can inline the std:: and remove the import to shorten the example.
Make each lint be more self-contained, and trigger only the next lint when the previous one didn't already rewrite the expression.
samueltardieu
force-pushed
the
push-qyyrwsvsuvyw
branch
2 times, most recently
from
538b71d to
86796f2
Compare
samueltardieu
force-pushed
the
push-qyyrwsvsuvyw
branch
from
86796f2 to
8daf0db
Compare
llogiq
approved these changes
Feb 12, 2025
`mem::replace(opt, Some(v))` can be replaced by `opt.replace(v)`.
samueltardieu
force-pushed
the
push-qyyrwsvsuvyw
branch
from
8daf0db to
342ac8e
Compare
|
Needs a |
|
Resubmitted with reformatted comment as the only change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem::replace(opt, Some(v))can be replaced byopt.replace(v).Close #14195
changelog: [
mem_replace_option_with_some]: new lint