fix: manual_let_else missing binding mode
#14204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
|
r? clippy still traveling |
|
r? clippy |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
profetia
force-pushed
the
issue13768
branch
2 times, most recently
from
c83a3a2 to
4679dda
Compare
|
Looks like it conflicted with the new mandatory test annotations. Anyway you may need to re-press the merge button @dswij |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13768
The existing implemention forgets to handle the binding mode (i.e.
refandref mut), so I just modified it to cover these cases.changelog: [
manual_let_else]: fix missing binding mode