Skip to content

Fix used_underscore_items lint uses of foreign functions #14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix used_underscore_items lint uses of foreign functions #14205

merged 1 commit into from
Feb 15, 2025

Conversation

WeiTheShinobi
Copy link
Contributor

Fixed #14156

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2025
Jarcho
Jarcho approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Feb 15, 2025
Merged via the queue into rust-lang:master with commit 0dd5c4d Feb 15, 2025
11 checks passed
@WeiTheShinobi WeiTheShinobi deleted the used_underscore_items_foreign_func branch March 15, 2025 10:53
yuki0iq added a commit to iex-rs/lithium that referenced this pull request Jun 3, 2025
@yuki0iq
Remove now-unneeded clippy::used_underscore_items for externs
d1bfbc1 
This fixes clippy on rust >= 1.87 under Itanium EH.

The lint was a false positive[0], and now does not fire[1].

[0]: rust-lang/rust-clippy#14156
[1]: rust-lang/rust-clippy#14205
purplesyringa pushed a commit to iex-rs/lithium that referenced this pull request Jun 3, 2025
@yuki0iq @purplesyringa
Remove now-unneeded clippy::used_underscore_items for externs
bb69448 
This fixes clippy on rust >= 1.87 under Itanium EH.

The lint was a false positive[0], and now does not fire[1].

[0]: rust-lang/rust-clippy#14156
[1]: rust-lang/rust-clippy#14205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

used_underscore_items should not warn about uses of foreign functions
3 participants
@WeiTheShinobi @rustbot @Jarcho