Skip to content

Make rust_tools_util package compatible with current stable by lowering rust edition to 2021. #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

Make rust_tools_util package compatible with current stable by lowering rust edition to 2021. #14211

merged 1 commit into from
Feb 14, 2025
+9 −9

Conversation

ignatz
Copy link
Contributor

@ignatz ignatz commented Feb 13, 2025 •
edited by flip1995
Loading

Between the release of v0.4.0 and v0.4.1 the edition was pushed to 2024 by a4805ff

changelog: Use edition=2021 in rustc_tools_util

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2025
@ignatz
Copy link
Contributor Author

ignatz commented Feb 13, 2025 •
edited
Loading

Adding @flip1995 for context

r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned Jarcho Feb 13, 2025
@flip1995
Copy link
Member

Whoops, my bad. Rust edition 2024 will hit stable in exactly 1 week. Do you mind waiting until then?

@ignatz
Copy link
Contributor Author

ignatz commented Feb 13, 2025 via email

@flip1995
Copy link
Member

Hm, crates published from the Clippy repo are kinda expected to be used with nightly. That might not apply to rustc_tools_util, as it doesn't need nightly. As we don't need the 2024 edition for this crate, I'm good with downgrading it again.

Please update the version of this crate everywhere though (except for lintcheck). Including Cargo.toml and rustc_tools_util/README.md.

@ignatz ignatz force-pushed the fix_rust_tools_util_stable branch from bb10264 to 6699292 Compare February 14, 2025 13:02
@ignatz
Copy link
Contributor Author

ignatz commented Feb 14, 2025

Please update the version of this crate everywhere though (except for lintcheck). Including Cargo.toml and rustc_tools_util/README.md.

Done

@flip1995 flip1995 force-pushed the fix_rust_tools_util_stable branch from 6699292 to f7f7888 Compare February 14, 2025 14:44
@flip1995
Copy link
Member

flip1995 commented Feb 14, 2025 •
edited
Loading

I added a comment, so that we don't accidentally update the edition of this crate in the future.

Will release, when merged.

@flip1995 flip1995 enabled auto-merge February 14, 2025 14:45
@flip1995 flip1995 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into rust-lang:master with commit 823b818 Feb 14, 2025
11 of 13 checks passed
@flip1995
Copy link
Member

Released to crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ignatz @rustbot @flip1995 @Jarcho