Skip to content

more natural suggestions for cmp_owned #14247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Feb 18, 2025

Dereferencing string literals in suggestions is redundant.

changelog: [cmp_owned]: more natural suggestions are provided for string literals now

fixes #8103

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 18, 2025
@lapla-cogito
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned llogiq and unassigned dswij Mar 5, 2025
@lapla-cogito
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Centri3 and unassigned llogiq Mar 21, 2025
@lapla-cogito
Copy link
Contributor Author

I didn't know that the person assigned via reroll doesn't necessarily match the one listed in triagebot.toml... I think this shouldn't be too difficult to review, but feel free to reroll if you'd like. @Centri3

@Centri3 Centri3 added this pull request to the merge queue Mar 27, 2025
Merged via the queue into rust-lang:master with commit 3e52867 Mar 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmp_owned provides a confusing suggestion
5 participants