Skip to content

rename MANUAL_DIV_CEIL MSRV alias and add missing conf info for manual_div_ceil #14263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

rename MANUAL_DIV_CEIL MSRV alias and add missing conf info for manual_div_ceil #14263

merged 2 commits into from
Feb 21, 2025

Conversation

lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Feb 20, 2025 •
edited
Loading

  • The name of an MSRV alias should describe its functionality, and it is not appropriate for it to be the same as the name of the lint that uses it.
  • Additionally, while manual_div_ceil allows setting MSRV, this is not correctly reflected in the configuration information.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 20, 2025
@samueltardieu samueltardieu mentioned this pull request Feb 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2025
@y21
Represent the capability instead of the lint name in msrv aliases (#1…
1250c26 
…4269)

`INTEGER_BITS` better represents the addition of the `BITS` value on the
primitive integer types.

Inspired by #14263

changelog: none
blyxyas
blyxyas approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Feb 21, 2025
Merged via the queue into rust-lang:master with commit 649cef0 Feb 21, 2025
13 checks passed
@lapla-cogito lapla-cogito mentioned this pull request Mar 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 8, 2025
@dswij
rename the MSRV alias MANUAL_DIV_CEIL to DIV_CEIL (#14329)
19930f9 
I renamed the MSRV alias `MANUAL_DIV_CEIL` to `DIV_CEIL` in #14263, as
MSRV aliases should represent their capability rather than the lint
name. However, it seems this change was mistakenly overwritten in
#14022.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lapla-cogito @rustbot @blyxyas