Extend {implicit,inverted}_saturating_sub to expressions
#14310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-xwurysoszlvz
branch
3 times, most recently
from
d40cee7 to
806547e
Compare
Side-effect free expressions are eligible to these lints, whereas previously only local variables were checked.
samueltardieu
force-pushed
the
push-xwurysoszlvz
branch
from
806547e to
029a6db
Compare
|
Rebased |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
implicit_saturating_sub,inverted_saturating_sub]: extend lints from local variables to side-effect free expressionsNoticed when #14308 introduced an implicit
saturating_suboperation and didn't get tagged.