add macos-latest as a CI target
#14342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Mar 10, 2025
Comment on lines
+30
to
+31
| - os: macos-latest | ||
| host: aarch64-apple-darwin |
There was a problem hiding this comment.
We might also want to add ubuntu-24.04-arm to this list, so we cover all Tier 1 targets.
There was a problem hiding this comment.
Yes. However, as you mentioned on Zulip, the GitHub-hosted runner for AArch64 Linux is currently in public preview, so I deliberately chose not to add it this time. If adding it with this patch isn't an issue, I can include it. What do you think?
There was a problem hiding this comment.
Let's see if someone replies on Zulip. If not, I'm also leaning towards not adding it in this PR.
There was a problem hiding this comment.
A day passes, and there seems to be no particular objection to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? flip1995
changelog: none