implicit_return: better handling of asynchronous code
#14446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-lyuvommpqwoq
branch
from
b4e7085 to
5e957c0
Compare
samueltardieu
force-pushed
the
push-lyuvommpqwoq
branch
2 times, most recently
from
1fce8ce to
2b85fc1
Compare
samueltardieu
changed the title
implicit_return: do not suggest adding return into desugared codeimplicit_return: better handling of asynchronous code
|
The 23 new hits during Lintcheck all seem legitimate. The 5 changes lints are due to the fact that an enclosing HIR node now gets the lint. Rerunning Clippy after fixing this would reach the inner expressions. |
Also, be stricter in matching the right expansion of async closures.
Blocks created by desugaring will not contain an explicit `return`. Do not suggest to add it when the user has no control over the desugared code. Also, in the case of an implicit return on a `.await` expression, ensure that the suggested `return` is emitted at the right place instead of before the `await` keyword.
samueltardieu
force-pushed
the
push-lyuvommpqwoq
branch
from
2b85fc1 to
4ac3611
Compare
|
Rebased |
|
r? clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks created by desugaring will not contain an explicit
return. Do not suggest to add it when the user has no control over the desugared code.Also, ensure that in a
xxx.awaitexpression, the suggestedreturnis emitted before the whole expression, not before theawaitkeyword.Fix #14411
changelog: [
implicit_return]: fix proposedreturnposition in the presence of asynchronous code