item_name_repetitions: exclude enum variants with identical path components
#14619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
samueltardieu is on vacation. Please choose another assignee. |
|
r? clippy |
Manishearth
reviewed
May 6, 2025
| check_enum_start(cx, item_name, var); | ||
| check_enum_end(cx, item_name, var); | ||
| } | ||
|
|
||
| Self::check_enum_common_affix(cx, item, def); | ||
| } | ||
|
|
||
| // Exclude enum variants that contain a single item where any component | ||
| // of the contained item's path is identical to the variant's name. | ||
| fn filter_matching_enum_data<'a>(def: &'a EnumDef<'a>) -> Vec<&'a Variant<'a>> { |
There was a problem hiding this comment.
issue: I don't think we should prefilter; we should instead perform this check in check_enum_start and check_enum_end after we think we want to lint on it (so we perform this more expensive check later)
There was a problem hiding this comment.
makes sense, I've made changes to reflect this
aaron-ang
force-pushed
the
enum-encapsulate
branch
from
088a429 to
9adf1f0
Compare
aaron-ang
force-pushed
the
enum-encapsulate
branch
from
9adf1f0 to
e89cf4d
Compare
Manishearth
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13637
As suggested in the PR above, we should not lint enum variants containing matching path names.
changelog: [
item_name_repetitions]: exclude enum variants with identical path components