Fix integer_division false negative for NonZero denominators

[alex-semenyuk]

Close #14652

changelog: [integer_division]: fix false negative for NonZero denominators

[rustbot]

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Failed to set assignee to Clippy: cannot assign: response: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/assignees#add-assignees-to-an-issue","status":"404"}

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[alex-semenyuk]

r? clippy

[blyxyas]

Great bugfix, althought I have some light comments =^w^= 🐱

[blyxyas]

Just for future resilience, could you also add a test for NonZero / <integer> and NonZero / NonZero

[alex-semenyuk]

Testing I see the following

error[E0369]: cannot divide std::num::NonZero<u32> by std::num::NonZero<u32>

the foreign item type std::num::NonZero<u32> doesn't implement std::ops::Div

and

error[E0369]: cannot divide std::num::NonZero<u32> by u32

 the foreign item type std::num::NonZero<u32> doesn't implement std::ops::Div<u32>

so I adjusted condition as well

[blyxyas]

Interesting, although I guess that makes sense because the only scenario where absolutely making sure that an integer is non-zero would be in the denominator.

[teor2345]

It would also be unintuitive (and non-composable), because NonZero(1) / NonZero(2) is zero, so the returned type would always have to be the underlying integer.

[blyxyas]

LGTM, thanks ❤️