Skip to content

Lint reversed ordering in partial ord impl #14945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Lint reversed ordering in partial ord impl #14945

merged 1 commit into from
Jun 3, 2025

Conversation

donkomura
Copy link
Contributor

@donkomura donkomura commented Jun 1, 2025 •
edited
Loading

Fixes #14574

Lint reversed ordering in partial ord impl

changelog: [non_canonical_partial_ord_impl] lint reversed ordering

@donkomura donkomura marked this pull request as ready for review June 1, 2025 05:55
@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2025
samueltardieu
samueltardieu requested changes Jun 1, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 1, 2025
@donkomura donkomura changed the title Improve PartialOrd lint to the _.cmp(self) pattern Improve PartialOrd lint for the _.cmp(self) pattern Jun 2, 2025
@donkomura donkomura requested a review from samueltardieu June 2, 2025 17:08
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 2, 2025
samueltardieu
samueltardieu requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. You'll have to reformat the commit message though, so that the initial line is no longer than the traditional git convention, here you'll see that git log shows you a truncated version that overflows into the longer commit message. Also, there is a typo in the message. And please squash the commits.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 2, 2025
@donkomura donkomura force-pushed the non_canonical_impls_ord_cmp branch from 97a14ca to 53babd6 Compare June 3, 2025 10:38
@donkomura
Copy link
Contributor Author

I've squashed the commits and fix the message. 53babd6

@donkomura donkomura requested a review from samueltardieu June 3, 2025 10:48
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 3, 2025
@donkomura donkomura changed the title Improve PartialOrd lint for the _.cmp(self) pattern Lint reversed ordering in partial ord impl Jun 3, 2025
@donkomura donkomura closed this Jun 3, 2025
@donkomura donkomura force-pushed the non_canonical_impls_ord_cmp branch from 53babd6 to 551870d Compare June 3, 2025 14:56
@donkomura @samueltardieu
Lint reversed ordering in partial ord impl
3b64c5c 
changelog: [non_canonical_partial_ord_impl] lint reversed ordering

Co-authored-by: Samuel Tardieu <[email protected]>
@donkomura donkomura reopened this Jun 3, 2025
@samueltardieu samueltardieu enabled auto-merge June 3, 2025 15:37
samueltardieu
samueltardieu approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samueltardieu samueltardieu added this pull request to the merge queue Jun 3, 2025
Merged via the queue into rust-lang:master with commit a4debd2 Jun 3, 2025
18 of 22 checks passed
@donkomura
Copy link
Contributor Author

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non_canonical_partial_ord_impl will not lint reversed ordering
3 participants
@donkomura @rustbot @samueltardieu