driver: Improve check for rustc arg #3130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rustc arg might not be exactly "rustc". It may be any path to a rustc executable (especially if the RUSTC environment variable is set when executing cargo). Rather check that it ends in `rustc` or `rust.exe`.
oli-obk
reviewed
Sep 5, 2018
| @@ -47,7 +47,7 @@ pub fn main() { | |||
| if orig_args.len() <= 1 { | |||
| std::process::exit(1); | |||
| } | |||
| if orig_args[1] == "rustc" { | |||
| if orig_args[1].ends_with("rustc") || orig_args[1].ends_with("rustc.exe") { | |||
There was a problem hiding this comment.
you could convert it to a Path and check the file_stem for equality to "rustc"
There was a problem hiding this comment.
This is a great idea. I'll submit a new PR.
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustc arg might not be exactly "rustc". It may be any path to a rustc
executable (especially if the RUSTC environment variable is set when
executing cargo). Rather check that it ends in
rustcorrust.exe.