fix some clippy::pedantic warnings found in the codebase. #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiaskrgr
changed the title
flip1995
reviewed
Sep 26, 2018
clippy_dev/src/lib.rs
Outdated
| @@ -46,12 +46,12 @@ impl Lint { | |||
| } | |||
|
|
|||
| /// Returns all non-deprecated lints | |||
| pub fn active_lints(lints: &[Lint]) -> impl Iterator<Item=&Lint> { | |||
| pub fn active_lints(lints: &[Self]) -> impl Iterator<Item=&Lint> { | |||
There was a problem hiding this comment.
Another Lint here. Does the use_self lint not trigger here?
There was a problem hiding this comment.
Yeah, it didn't, is it a FN?
There was a problem hiding this comment.
Seems like it. It works with Self, so I guess this is unintended. Playground
There was a problem hiding this comment.
I updated the pr and added the change.
Can you file a ticket about the FN with your snipped please?
matthiaskrgr
force-pushed
the
clippy_self__use_self
branch
from
9add862 to
9fae469
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #3172