simplify ci scripts #3364
simplify ci scripts #3364
Conversation
ci/base-tests.sh
Outdated
| do | ||
| cd ${dir} | ||
| ${CLIPPY} -- -D clippy::all | ||
| cd ${CWD_OLD} |
There was a problem hiding this comment.
Maybe pushd and popd since Travis uses bash?
There was a problem hiding this comment.
I don't understand.
The bash script and cd'ing inside it should work just fine on travis?
There was a problem hiding this comment.
Ah no, it will definitely work. pushd & popd was just a suggestion for readability and to me it looked like an easy "-1 LoC optimization" :D.
There was a problem hiding this comment.
Mh, I am not familiar with pushd and popd and have never used them so I would rather keep it the current way, but thanks for the suggestion :)
There was a problem hiding this comment.
I am not familiar with
pushdandpopdand have never used them
They manage the directory stack in your shell:
[user@server /usr/ports] $ pushd /etc
/etc /usr/ports
[user@server /etc] $ popd
/usr/ports
[user@server /usr/ports] $This may come in handy when you need to quickly jump back and forth between directories without having to save all old locations in variables.
There was a problem hiding this comment.
Since this is just going back and forth between two directories, I think pushd and popd are not really needed here. But the cd ${CWD_OLD} can be replaced with cd -, so we don't need to store CWD_OLD.
matthiaskrgr
added
the
S-waiting-on-review
matthiaskrgr
force-pushed
the
ci_simplify
branch
from
f48ca43 to
a90084d
Compare
|
bors r+ |
3364: simplify ci scripts r=phansch a=matthiaskrgr This makes it easier to flip the switch on pedantic lints on the clippy codebase. Co-authored-by: Matthias Krüger <[email protected]>
This makes it easier to flip the switch on pedantic lints on the clippy codebase.