Skip to content

rustfmt everything once and for all #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 28, 2018
Merged

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 27, 2018

Closes #3460

What's done in this PR:

  • Format everything
  • Install and run rustfmt on travis
  • Update CONTRIBUTING.md to tell contributors about rustfmt (and overdue license change)
  • Set error_on_line_overflow in rustfmt.toml

I'm sorry @ everyone who has an open PR... 😞

@flip1995
Copy link
Member Author

flip1995 commented Nov 27, 2018

I thought about the suggestion #3460 (comment) by @waynr. But having a test with rustfmt that is run with cargo test would require that the contributor has rustfmt installed for cargo test to pass. IMO cargo test shouldn't depend on other tools.

@flip1995 flip1995 closed this Nov 28, 2018
@flip1995 flip1995 reopened this Nov 28, 2018
@oli-obk oli-obk merged commit f583152 into rust-lang:master Nov 28, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2018

Awesome!

@waynr
Copy link
Contributor

waynr commented Nov 28, 2018

@flip1995 that makes sense. I would only point out that there is now an implicit dependency that users install and run rustfmt anyway in order to get their PRs merged which could lead to more abandoned PRs by hit-and-run contributors like myself ;)

@flip1995 flip1995 deleted the rustfmt branch November 28, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants