wildcard_enum_match_arm gives suggestions #3729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
match_enum_wildcard
branch
from
e3ccc15 to
e9119ab
Compare
phansch
added
the
S-waiting-on-review
illicitonion
force-pushed
the
match_enum_wildcard
branch
from
e9119ab to
c7c7e9d
Compare
flip1995
reviewed
Feb 5, 2019
|
Also this needs to be fixed: |
And is also more robust
Also, fix existing test
illicitonion
force-pushed
the
match_enum_wildcard
branch
from
40650cc to
bcefd68
Compare
|
Thanks! @bors r+ |
|
📌 Commit 4009a44 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 18, 2019
wildcard_enum_match_arm gives suggestions And is also more robust
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And is also more robust