use a multispan for MANY_SINGLE_CHAR_NAMES #3921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
force-pushed
the
single-char-names-multispan
branch
from
dce8d99 to
127fa6b
Compare
flip1995
added
the
S-waiting-on-review
euclio
force-pushed
the
single-char-names-multispan
branch
from
127fa6b to
0d50d44
Compare
flip1995
approved these changes
Apr 5, 2019
|
Thanks, this looks really good! Was there an Issue for this or was it just something you wanted to be improved? There's currently a pile of PRs waiting to be merged once Clippy builds again. I just throw this PR on this pile. There should be nothing you have to do for this to get merged, but wait. |
|
No issue, just a potential improvement that I spotted. Sounds good, thanks! |
|
@bors r+ |
|
📌 Commit 0d50d44 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 8, 2019
use a multispan for MANY_SINGLE_CHAR_NAMES
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.