Only run AppVeyor on r+, try and the master branch #4028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only.
|
It seems the PR is still being built even with the updated branch restrictions? |
|
AFAICT someone with permissions has to check 'Do not build on "Pull request" events' near the bottom at https://ci.appveyor.com/project/rust-lang-libs/rust-clippy/settings |
phansch
added
the
S-waiting-on-review
|
Done. |
|
Looks like it works. Only Travis has been triggered by the re-open =) Thanks @Manishearth! @bors r+ |
|
📌 Commit 8d7a5fe has been approved by |
bors
added a commit
that referenced
this pull request
Apr 25, 2019
Only run AppVeyor on r+, try and the master branch As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only.
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 8d7a5fe has been approved by |
bors
added a commit
that referenced
this pull request
Apr 25, 2019
Only run AppVeyor on r+, try and the master branch As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only.
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Apr 25, 2019
Only run AppVeyor on r+, try and the master branch As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is right now, there is only one worker available in the
rust-lang-libsAppVeyor project and there are other repos as well that we share this worker
with. This has been a problem for us because we sometimes hit a bors timeout if there
are too many builds queued up.
To improve the situation, I think we could try to use AppVeyor a bit less
often. The average PR is not going to break windows related things anyway, so
it should be fine to run it on r+/try/master only.
changelog: none