Skip to content

Do not install rustup-toolchain if it is in PATH #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 3, 2019

I find it quiet annoying because I manually build rustup-toolchain-install-master
and install it in PATH other than in ~/.cargo/bin. So everytime I run the script,
it always reinstall rustup-toolchain-install-master for me.

changelog: none

@flip1995
Copy link
Member

flip1995 commented Jun 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jun 3, 2019

📌 Commit 3fb497c has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 3, 2019

⌛ Testing commit 3fb497c with merge 20da8f4...

bors added a commit that referenced this pull request Jun 3, 2019
Do not install rustup-toolchain if it is in PATH

I find it quiet annoying because I manually build `rustup-toolchain-install-master`
and install it in `PATH` other than in `~/.cargo/bin`. So everytime I run the script,
it always reinstall `rustup-toolchain-install-master` for me.

changelog: none
@bors
Copy link
Contributor

bors commented Jun 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 20da8f4 to master...

@bors bors merged commit 3fb497c into rust-lang:master Jun 3, 2019
@tesuji tesuji deleted the fix-script branch June 3, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants